Messages in this thread | | | From | Andy Shevchenko <> | Date | Thu, 1 Mar 2018 11:32:47 +0200 | Subject | Re: [PATCH v5 01/12] drivers: base: Unified device connection lookup |
| |
On Thu, Mar 1, 2018 at 9:28 AM, Heikki Krogerus <heikki.krogerus@linux.intel.com> wrote: > Hi, > > On Thu, Mar 01, 2018 at 12:56:57AM +0000, Jun Li wrote: >> > +struct device *device_find_connection(struct device *dev, const char >> > +*con_id) { >> > + return __device_find_connection(dev, con_id, generic_match, NULL); } >> >> - return __device_find_connection(dev, con_id, generic_match, NULL); >> + return __device_find_connection(dev, con_id, NULL, generic_match); > > Good catch!
It seems I proposed to put function first parameter followed by opaque data pointer for it. In that case it would be exactly like now.
Though, I didn't check if the parameter ordering was changed in the prototype.
-- With Best Regards, Andy Shevchenko
| |