lkml.org 
[lkml]   [2018]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH v5 01/12] dax: fix vma_is_fsdax() helper
    From
    Date
    Gerd reports that ->i_mode may contain other bits besides S_IFCHR. Use
    S_ISCHR() instead. Otherwise, get_user_pages_longterm() may fail on
    device-dax instances when those are meant to be explicitly allowed.

    Fixes: 2bb6d2837083 ("mm: introduce get_user_pages_longterm")
    Cc: <stable@vger.kernel.org>
    Reported-by: Gerd Rausch <gerd.rausch@oracle.com>
    Acked-by: Jane Chu <jane.chu@oracle.com>
    Reported-by: Haozhong Zhang <haozhong.zhang@intel.com>
    Reviewed-by: Jan Kara <jack@suse.cz>
    Signed-off-by: Dan Williams <dan.j.williams@intel.com>
    ---
    include/linux/fs.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/include/linux/fs.h b/include/linux/fs.h
    index 2a815560fda0..79c413985305 100644
    --- a/include/linux/fs.h
    +++ b/include/linux/fs.h
    @@ -3198,7 +3198,7 @@ static inline bool vma_is_fsdax(struct vm_area_struct *vma)
    if (!vma_is_dax(vma))
    return false;
    inode = file_inode(vma->vm_file);
    - if (inode->i_mode == S_IFCHR)
    + if (S_ISCHR(inode->i_mode))
    return false; /* device-dax */
    return true;
    }
    \
     
     \ /
      Last update: 2018-03-02 05:07    [W:4.155 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site