lkml.org 
[lkml]   [2018]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 03/22] kbuild: rpm-pkg: keep spec file until make mrproper
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Masahiro Yamada <yamada.masahiro@socionext.com>

    commit af60e207087975d069858741c44ed4f450330ac4 upstream.

    If build fails during (bin)rpm-pkg, the spec file is not cleaned by
    anyone until the next successful build of the package.

    We do not have to immediately delete the spec file in case somebody
    may want to take a look at it. Instead, make them ignored by git,
    and cleaned up by make mrproper.

    Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    .gitignore | 5 +++++
    scripts/package/Makefile | 4 ++--
    2 files changed, 7 insertions(+), 2 deletions(-)

    --- a/.gitignore
    +++ b/.gitignore
    @@ -56,6 +56,11 @@ modules.builtin
    /Module.markers

    #
    +# RPM spec file (make rpm-pkg)
    +#
    +/*.spec
    +
    +#
    # Debian directory (make deb-pkg)
    #
    /debian/
    --- a/scripts/package/Makefile
    +++ b/scripts/package/Makefile
    @@ -50,7 +50,6 @@ rpm-pkg rpm: FORCE
    $(CONFIG_SHELL) $(MKSPEC) >$(objtree)/kernel.spec
    $(call cmd,src_tar,$(KERNELPATH),kernel.spec)
    +rpmbuild $(RPMOPTS) --target $(UTS_MACHINE) -ta $(KERNELPATH).tar.gz
    - rm $(KERNELPATH).tar.gz kernel.spec

    # binrpm-pkg
    # ---------------------------------------------------------------------------
    @@ -59,7 +58,8 @@ binrpm-pkg: FORCE
    $(CONFIG_SHELL) $(MKSPEC) prebuilt > $(objtree)/binkernel.spec
    +rpmbuild $(RPMOPTS) --define "_builddir $(objtree)" --target \
    $(UTS_MACHINE) -bb $(objtree)/binkernel.spec
    - rm binkernel.spec
    +
    +clean-files += $(objtree)/*.spec

    # Deb target
    # ---------------------------------------------------------------------------

    \
     
     \ /
      Last update: 2018-02-09 14:46    [W:3.652 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site