Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 9 Feb 2018 15:21:17 +0200 | Subject | Re: [PATCH] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication |
| |
On Fri, Feb 9, 2018 at 8:58 AM, Donglin Peng <dolinux.peng@gmail.com> wrote: > There is some duplicate code in soc-core.c,and the kernel provides
'core.c,and' -> 'core.c, and'
> +static int codec_list_show(struct seq_file *s, void *v)
No need to rename m -> s.
> +static int dai_list_show(struct seq_file *s, void *v)
Ditto.
> +static int platform_list_show(struct seq_file *s, void *v)
Ditto.
After addressing above,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
-- With Best Regards, Andy Shevchenko
| |