lkml.org 
[lkml]   [2018]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] scsi: ufs: fix exception event handling
On 2018-01-28 20:34, Asutosh Das wrote:
> From: Maya Erez <merez@codeaurora.org>
>
> The device can set the exception event bit in one of the response UPIU,
> for example to notify the need for urgent BKOPs operation.
> In such a case the host driver calls ufshcd_exception_event_handler to
> handle this notification.
> When trying to check the exception event status (for finding the cause
> for
> the exception event), the device may be busy with additional SCSI
> commands
> handling and may not respond within the 100ms timeout.
>
> To prevent that, we need to block SCSI commands during handling of
> exception events and allow retransmissions of the query requests,
> in case of timeout.
>
> Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
> Signed-off-by: Maya Erez <merez@codeaurora.org>
> Signed-off-by: Can Guo <cang@codeaurora.org>
> Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
> ---
> drivers/scsi/ufs/ufshcd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 8af2af3..2dd488f 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -4955,6 +4955,7 @@ static void
> ufshcd_exception_event_handler(struct work_struct *work)
> hba = container_of(work, struct ufs_hba, eeh_work);
>
> pm_runtime_get_sync(hba->dev);
> + scsi_block_requests(hba->host);
> err = ufshcd_get_ee_status(hba, &status);
> if (err) {
> dev_err(hba->dev, "%s: failed to get exception status %d\n",
> @@ -4968,6 +4969,7 @@ static void
> ufshcd_exception_event_handler(struct work_struct *work)
> ufshcd_bkops_exception_event_handler(hba);
>
> out:
> + scsi_unblock_requests(hba->host);
> pm_runtime_put_sync(hba->dev);
> return;
> }

Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>

--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

\
 
 \ /
  Last update: 2018-02-08 18:54    [W:0.033 / U:2.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site