Messages in this thread | | | From | Linus Torvalds <> | Date | Thu, 8 Feb 2018 09:39:31 -0800 | Subject | Re: [RFC v2 PATCH 6/7] x86/entry: get rid of ALLOC_PT_GPREGS_ON_STACK and SAVE_AND_CLEAR_REGS |
| |
On Thu, Feb 8, 2018 at 1:47 AM, Ingo Molnar <mingo@kernel.org> wrote: > > So for those reasons I'm really tempted by the all around simplification offered > by this series: > > 2 files changed, 62 insertions(+), 160 deletions(-) > > Basically in this specific case I'd like to turn the argument around, > use this simpler design and put the burden of proof on the patches that > want to _complicate it_ beyond this simple, straightforward model
You make a good argument.
If the only real downside is slightly bigger static footprint (but the actual real dynamic I$ footprint is not really impacted), then let's just go for the simpler code.
It really would be lovely if our entry asm was understandable to mere mortals.
Linus
| |