Messages in this thread | | | Date | Thu, 8 Feb 2018 14:47:10 +0800 | From | Shawn Guo <> | Subject | Re: [PATCH v2 1/2] soc: imx: gpcv2: Do not pass static memory as platform data |
| |
On Mon, Jan 22, 2018 at 07:07:47AM -0800, Andrey Smirnov wrote: > Platform device core assumes the ownership of dev.platform_data as > well as that it is dynamically allocated and it will try to kfree it > as a part of platform_device_release(). Change the code to pass > kzalloc'ed chunk of memory instead of a pointer to a static memory to > avoid causing a BUG() when calling platform_device_put(). > > The problem can be reproduced by artificially enabling the error path > of platform_device_add() call (around line 357). > > Note that this change also allows us to constify imx7_pgc_domains, > since we no longer need to be able to modify it. > > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Stefan Agner <stefan@agner.ch> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Applied both, thanks.
| |