Messages in this thread | | | From | Masahiro Yamada <> | Date | Thu, 8 Feb 2018 10:02:39 +0900 | Subject | Re: [PATCH v3 12/16] mmc: tmio: support IP-builtin card detection logic |
| |
2018-02-08 4:34 GMT+09:00 Wolfram Sang <wsa@the-dreams.de>: > On Thu, Jan 18, 2018 at 01:28:12AM +0900, Masahiro Yamada wrote: >> A card detect GPIO is set up only for platforms with "cd-gpios" >> DT property or TMIO_MMC_USE_GPIO_CD flag. However, the driver >> core always uses mmc_gpio_get_cd, which just fails with -ENOSYS >> if ctx->cd_gpio is unset. >> >> The bit 5 of the status register provides the current signal level >> of the CD line. Allow to use it if the GPIO is unused. >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > >> @@ -1095,7 +1103,7 @@ static const struct mmc_host_ops tmio_mmc_ops = { > > I just wonder why the diff-tool puts 'const' in the definition. There is > no const in my version here. And there shouldn't be because we modify > the struct in this patch. >
Which kernel version are you seeing?
The following patch was applied and it is in Linus'tree.
commit c055fc75c1757b220108489038cfe60496b13865 Author: Masahiro Yamada <yamada.masahiro@socionext.com> Date: Sat Nov 25 01:24:41 2017 +0900
mmc: tmio: move mmc_host_ops to struct tmio_mmc_host from static data
Currently, tmio_mmc_ops is static data and tmio_mmc_host_probe() updates some hooks in the static data. This is a problem when two or more instances call tmio_mmc_host_probe() and each of them requests to use its own card_busy/start_signal_voltage_switch.
We can borrow a solution from sdhci_alloc_host(). Copy the whole ops structure to host->mmc_host_ops, then override the hooks in malloc'ed data. Constify tmio_mmc_ops since it is now a template ops used by default.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
-- Best Regards Masahiro Yamada
| |