Messages in this thread | | | Subject | Re: [PATCH 2/8] ASoC: samsung: i2s: Ensure names of supplied clocks are unique | From | Sylwester Nawrocki <> | Date | Wed, 07 Feb 2018 16:20:56 +0100 |
| |
On 02/06/2018 01:20 PM, Krzysztof Kozlowski wrote: >> @@ -1214,30 +1216,35 @@ static int i2s_register_clock_provider(struct platform_device *pdev) >> clk_put(rclksrc); >> } >> >> + for (i = 0; i < ARRAY_SIZE(i2s_clk_desc); i++) >> + i2s_clk_name[i] = devm_kasprintf(dev, GFP_KERNEL, "%s_%s", >> + dev_name(dev), i2s_clk_desc[i]); > > kasprintf() might return NULL and later it is being used as clock > name. I think you should handle such error.
Right, I will fix that in next version, thanks for your review.
-- Regards, Sylwester
| |