lkml.org 
[lkml]   [2018]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 07/10] ARM: sun8i: h3: add SY8113B regulator used by Orange Pi One board
    On Tue, Feb 06, 2018 at 12:49:02PM +0800, Icenowy Zheng wrote:
    > Orange Pi One board has a SY8113B regulator, which is controlled via
    > GPIO and capable of outputing 1.1V when the PL6 GPIO is set to output 0
    > or 1.3V when the PL6 GPIO is set to input or output 1, and the output is
    > the power supply of the ARM cores in H3 SoC.
    >
    > Add the device tree node of this regulator and set the cpu's cpu-supply
    > property to it.
    >
    > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
    > ---
    > New patch in v2.
    >
    > arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 21 +++++++++++++++++++++
    > 1 file changed, 21 insertions(+)
    >
    > diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
    > index 82e5d28cd698..d8250aacfda1 100644
    > --- a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
    > +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
    > @@ -88,6 +88,27 @@
    > gpios = <&r_pio 0 3 GPIO_ACTIVE_LOW>;
    > };
    > };
    > +
    > + reg_sy8113b: gpio-regulator {

    There's multiple of them on those boards, so the name and label should
    avoid conflicting names (this also applies to your other patches).

    Maxime

    --
    Maxime Ripard, Bootlin (formerly Free Electrons)
    Embedded Linux and Kernel engineering
    http://bootlin.com
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2018-02-06 10:12    [W:4.813 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site