Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 6 Feb 2018 20:51:58 +0200 | Subject | Re: [PATCH] printk: Print error pointers as negative integers for %p |
| |
On Tue, Feb 6, 2018 at 11:21 AM, David Howells <dhowells@redhat.com> wrote: > The new hashing feature of unadorned printk("%p") makes it hard to spot if > the pointer actually carries an error value. Make %p print any pointer > that matches IS_ERR() as a negative integer. > > Should I set SMALL and the field_width as well, I wonder?
> + spec.type = FORMAT_TYPE_INT;
_LONG ?
For sake of consistency.
-- With Best Regards, Andy Shevchenko
| |