Messages in this thread Patch in this message | | | From | sztsian@gmail ... | Subject | [PATCH 2/2] trace-cmd: Change the way of getting python ldflags. | Date | Sun, 4 Feb 2018 11:20:14 +0800 |
| |
From: Zamir SUN <sztsian@gmail.com>
Prior than this patch, Makefile detects python ldflags using a hardcoded python command. It will cause problems if we are building against python3 in the future when ldflags for python2 and python3 are different. With this patch, python ldflags are detected by corresponding python{,3}-config which will detect the right config for python plugins.
Signed-off-by: Zamir SUN (Red Hat) <sztsian@gmail.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile index 7c0d1a6..f41e399 100644 --- a/Makefile +++ b/Makefile @@ -636,7 +636,7 @@ report_noswig: force PYTHON_INCLUDES = `pkg-config --cflags $(PYTHON_VERS)` PYTHON_LDFLAGS = `pkg-config --libs $(PYTHON_VERS)` \ - $(shell python2 -c "import distutils.sysconfig; print distutils.sysconfig.get_config_var('LINKFORSHARED')") + $(shell $(PYTHON_VERS)-config --ldflags) PYGTK_CFLAGS = `pkg-config --cflags pygtk-2.0` ctracecmd.so: $(TCMD_LIB_OBJS) ctracecmd.i -- 2.14.3
| |