lkml.org 
[lkml]   [2018]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 050/254] ALSA: usb-audio: Add check return value for usb_string()
    3.16.55-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jaejoong Kim <climbbb.kim@gmail.com>

    commit 89b89d121ffcf8d9546633b98ded9d18b8f75891 upstream.

    snd_usb_copy_string_desc() returns zero if usb_string() fails.
    In case of failure, we need to check the snd_usb_copy_string_desc()'s
    return value and add an exception case

    Signed-off-by: Jaejoong Kim <climbbb.kim@gmail.com>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    sound/usb/mixer.c | 9 +++++----
    1 file changed, 5 insertions(+), 4 deletions(-)

    --- a/sound/usb/mixer.c
    +++ b/sound/usb/mixer.c
    @@ -2100,13 +2100,14 @@ static int parse_audio_selector_unit(str
    if (len)
    ;
    else if (nameid)
    - snd_usb_copy_string_desc(state, nameid, kctl->id.name,
    + len = snd_usb_copy_string_desc(state, nameid, kctl->id.name,
    sizeof(kctl->id.name));
    - else {
    + else
    len = get_term_name(state, &state->oterm,
    kctl->id.name, sizeof(kctl->id.name), 0);
    - if (!len)
    - strlcpy(kctl->id.name, "USB", sizeof(kctl->id.name));
    +
    + if (!len) {
    + strlcpy(kctl->id.name, "USB", sizeof(kctl->id.name));

    if (desc->bDescriptorSubtype == UAC2_CLOCK_SELECTOR)
    append_ctl_name(kctl, " Clock Source");
    \
     
     \ /
      Last update: 2018-02-28 18:01    [W:4.062 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site