Messages in this thread | | | Date | Wed, 28 Feb 2018 08:56:33 +0100 | From | Michael Moese <> | Subject | Re: [PATCH] 8250-men-mcb: add support for 16z025 and 16z057 |
| |
Hi, Thanks for your comments. Let me briefly respond.
On Tue, Feb 27, 2018 at 07:57:34PM +0200, Andy Shevchenko wrote: > On Tue, Feb 27, 2018 at 5:31 PM, Michael Moese <mmoese@suse.de> wrote: > > - else if (strncmp(mdev->bus->name, "F216", 4) == 0) > > + else if (strncmp(mdev->bus->name, "F216", 4) == 0) > > What's changed? There were two spaces after that if.
> > + switch (mdev->id) { > > + case MEN_UART_ID_Z125: > > + num_ports = 1U; > > + break; > > + case MEN_UART_ID_Z025: > > + num_ports = readb(membase) >> 4; > > + break; > > + case MEN_UART_ID_Z057: > > + num_ports = 4U; > > + break; > > + default: > > + dev_err(&mdev->dev, "no supported device!\n"); > > + return -ENODEV; > > + } > > (1) > > > + data[i].uart.port.mapbase = (unsigned long) mem->start > > + + (i * MEN_UART_MEM_SIZE); > > Redundant parens. Well, let me remove them. Gonna do a v2 anyway.
> > > + switch (mdev->id) { > > + case MEN_UART_ID_Z125: > > + num_ports = 1U; > > + break; > > + case MEN_UART_ID_Z025: > > + num_ports = readb(data[0].uart.port.membase) >> 4; > > + break; > > + case MEN_UART_ID_Z057: > > + num_ports = 4U; > > + break; > > + default: > > + dev_err(&mdev->dev, "no supported device!\n"); > > + return; > > + } > > Can you deduplicate this with (1)? Well, that sounds like a good idea. Will do this.
> -- > With Best Regards, > Andy Shevchenko
Thanks, Michael -- SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
| |