lkml.org 
[lkml]   [2018]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 066/254] net: mvmdio: disable/unprepare clocks in EPROBE_DEFER case
    3.16.55-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Tobias Jordan <Tobias.Jordan@elektrobit.com>

    commit 589bf32f09852041fbd3b7ce1a9e703f95c230ba upstream.

    add appropriate calls to clk_disable_unprepare() by jumping to out_mdio
    in case orion_mdio_probe() returns -EPROBE_DEFER.

    Found by Linux Driver Verification project (linuxtesting.org).

    Fixes: 3d604da1e954 ("net: mvmdio: get and enable optional clock")
    Signed-off-by: Tobias Jordan <Tobias.Jordan@elektrobit.com>
    Reviewed-by: Andrew Lunn <andrew@lunn.ch>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/net/ethernet/marvell/mvmdio.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/net/ethernet/marvell/mvmdio.c
    +++ b/drivers/net/ethernet/marvell/mvmdio.c
    @@ -241,7 +241,8 @@ static int orion_mdio_probe(struct platf
    dev->regs + MVMDIO_ERR_INT_MASK);

    } else if (dev->err_interrupt == -EPROBE_DEFER) {
    - return -EPROBE_DEFER;
    + ret = -EPROBE_DEFER;
    + goto out_mdio;
    }

    mutex_init(&dev->lock);
    \
     
     \ /
      Last update: 2018-02-28 17:36    [W:2.042 / U:0.432 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site