lkml.org 
[lkml]   [2018]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 056/254] net_sched: red: Avoid devision by zero
    3.16.55-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Nogah Frankel <nogahf@mellanox.com>

    commit 5c472203421ab4f928aa1ae9e1dbcfdd80324148 upstream.

    Do not allow delta value to be zero since it is used as a divisor.

    Fixes: 8af2a218de38 ("sch_red: Adaptative RED AQM")
    Signed-off-by: Nogah Frankel <nogahf@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    include/net/red.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/include/net/red.h
    +++ b/include/net/red.h
    @@ -178,7 +178,7 @@ static inline void red_set_parms(struct
    p->qth_max = qth_max << Wlog;
    p->Wlog = Wlog;
    p->Plog = Plog;
    - if (delta < 0)
    + if (delta <= 0)
    delta = 1;
    p->qth_delta = delta;
    if (!max_P) {
    \
     
     \ /
      Last update: 2018-02-28 17:32    [W:2.988 / U:0.584 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site