lkml.org 
[lkml]   [2018]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 035/140] can: ems_usb: cancel urb on -EPIPE and -EPROTO
    3.2.100-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Martin Kelly <mkelly@xevo.com>

    commit bd352e1adfe0d02d3ea7c8e3fb19183dc317e679 upstream.

    In mcba_usb, we have observed that when you unplug the device, the driver will
    endlessly resubmit failing URBs, which can cause CPU stalls. This issue
    is fixed in mcba_usb by catching the codes seen on device disconnect
    (-EPIPE and -EPROTO).

    This driver also resubmits in the case of -EPIPE and -EPROTO, so fix it
    in the same way.

    Signed-off-by: Martin Kelly <mkelly@xevo.com>
    Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/net/can/usb/ems_usb.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/net/can/usb/ems_usb.c
    +++ b/drivers/net/can/usb/ems_usb.c
    @@ -292,6 +292,8 @@ static void ems_usb_read_interrupt_callb

    case -ECONNRESET: /* unlink */
    case -ENOENT:
    + case -EPIPE:
    + case -EPROTO:
    case -ESHUTDOWN:
    return;

    \
     
     \ /
      Last update: 2018-02-28 16:31    [W:4.136 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site