Messages in this thread | | | Subject | Re: [PATCH v4 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector | From | Andrzej Hajda <> | Date | Wed, 28 Feb 2018 07:39:34 +0100 |
| |
On 27.02.2018 22:24, Rob Herring wrote: > On Wed, Feb 21, 2018 at 2:55 AM, Andrzej Hajda <a.hajda@samsung.com> wrote: >> OF graph describes MHL data lanes between MHL and respective USB >> connector. >> >> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >> --- >> v4: >> - added missing reg property in connector's port node (Krzysztof) >> --- >> .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 32 ++++++++++++++++++++-- >> 1 file changed, 29 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> index f604f6b1a9c2..2ed506df94d0 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> @@ -817,9 +817,22 @@ >> clocks = <&pmu_system_controller 0>; >> clock-names = "xtal"; >> >> - port { >> - mhl_to_hdmi: endpoint { >> - remote-endpoint = <&hdmi_to_mhl>; >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + mhl_to_hdmi: endpoint { >> + remote-endpoint = <&hdmi_to_mhl>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + mhl_to_musb_con: endpoint { >> + remote-endpoint = <&musb_con_to_mhl>; >> + }; > These ports are mutually exclusive, right? If so, it should be 1 port > with 2 endpoints. Ports should represent independent data flows. > Something muxed or replicated (1 to many connection) should be be > endpoints.
No, this is HDMI -> MHL bridge, so port 0 is HDMI input, and port 1 is MHL output.
Regards Andrzej
> > Rob > > >
| |