Messages in this thread Patch in this message | | | From | Thomas Richter <> | Subject | [PATCH 1/2] perf annotate: Remove s390 basr instruction from call table | Date | Wed, 28 Feb 2018 14:33:08 +0100 |
| |
Perf annotate displays function call assembler instructions with a right arrow. Hitting enter on this line/instruction causes the browser to disassemble this target function and show it on the screen.
S390 assembler instruction 'basr %r1,%r2' jumps to address stored in register 2. Since the target address is unknown to perf it can not be handled.
Therefore remove the right arrow from such an instruction as the target function can not be identified.
Signed-off-by: Thomas Richter <tmricht@linux.vnet.ibm.com> Reviewed-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com> --- tools/perf/arch/s390/annotate/instructions.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/perf/arch/s390/annotate/instructions.c b/tools/perf/arch/s390/annotate/instructions.c index 8c72b44444cb..05f53bd092d4 100644 --- a/tools/perf/arch/s390/annotate/instructions.c +++ b/tools/perf/arch/s390/annotate/instructions.c @@ -12,8 +12,7 @@ static struct ins_ops *s390__associate_ins_ops(struct arch *arch, const char *na ops = &jump_ops; /* override call/returns */ if (!strcmp(name, "bras") || - !strcmp(name, "brasl") || - !strcmp(name, "basr")) + !strcmp(name, "brasl")) ops = &call_ops; if (!strcmp(name, "br")) ops = &ret_ops; -- 2.14.3
| |