lkml.org 
[lkml]   [2018]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v5 2/2] KVM: X86: Allow userspace to define the microcode version
2018-02-28 13:55 GMT+08:00 Tom Lendacky <thomas.lendacky@amd.com>:
> On 2/27/2018 9:34 PM, Wanpeng Li wrote:
>> From: Wanpeng Li <wanpengli@tencent.com>
>>
>> Linux (among the others) has checks to make sure that certain features
>> aren't enabled on a certain family/model/stepping if the microcode version
>> isn't greater than or equal to a known good version.
>>
>> By exposing the real microcode version, we're preventing buggy guests that
>> don't check that they are running virtualized (i.e., they should trust the
>> hypervisor) from disabling features that are effectively not buggy.
>>
>> Suggested-by: Filippo Sironi <sironi@amazon.de>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Radim Krčmář <rkrcmar@redhat.com>
>> Cc: Liran Alon <liran.alon@oracle.com>
>> Cc: Nadav Amit <nadav.amit@gmail.com>
>> Cc: Borislav Petkov <bp@alien8.de>
>> Cc: Tom Lendacky <thomas.lendacky@amd.com>
>> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
>> ---
>> v4 -> v5:
>> * microcode_version be u64 and initialized suitable, remote hte shifts
>> v3 -> v4:
>> * add the shifts back
>> v2 -> v3:
>> * remove the shifts
>> * add the MSR_IA32_UCODE_REV version to the "feature MSRs"
>
> I think you lost this part from the patch series. I don't see where you
> add MSR_IA32_UCODE_REV to the msr_based_features array.

I sent out a wrong version, will send again.

Regards,
Wanpeng Li

\
 
 \ /
  Last update: 2018-02-28 07:00    [W:0.044 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site