lkml.org 
[lkml]   [2018]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4
* Rob Herring <robh@kernel.org> [180219 20:41]:
> On Sat, Feb 17, 2018 at 01:07:23PM -0800, Tony Lindgren wrote:
> > The GPIOs controlling MDM6600 are used to power MDM660 on and off, to
>
> MDM660 a typo?

Thanks fixing.

> > +Required properties:
> > +- compatible Must be "motorola,mapphone-mdm6600"
> > +- enable-gpios GPIO to enable the USB PHY
> > +- power-gpios GPIO to power on the device
> > +- reset-gpios GPIO to reset the device
>
> The are pretty standard, but...
>
> > +- mode-gpios Two GPIOs to configure MDM6600 USB start-up mode for
> > + normal mode versus USB flashing mode
> > +- status-gpios Three GPIOs to read the power state of the MDM6600
> > +- cmd-gpios Three GPIOs to control the power state of the MDM6600
>
> These 3 should have vendor a prefix.

OK

> > +
> > +Example:
> > +
> > +fsusb1_phy: fsusb1_phy {
>
> usb-phy {

Thanks will send out an updated version shortly.

Regards,

Tony

\
 
 \ /
  Last update: 2018-03-01 04:54    [W:0.063 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site