Messages in this thread | | | Date | Thu, 1 Mar 2018 07:52:48 +0800 | From | kbuild test robot <> | Subject | Re: [PATCH v4] usb: core: Add "quirks" parameter for usbcore |
| |
Hi Kai-Heng,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing] [also build test ERROR on v4.16-rc3 next-20180228] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Kai-Heng-Feng/usb-core-Add-quirks-parameter-for-usbcore/20180227-211635 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: tile-tilegx_defconfig (attached as .config) compiler: tilegx-linux-gcc (GCC) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=tile
All errors (new ones prefixed by >>):
>> drivers/usb/core/quirks.c:15:43: error: expected ')' before 'sizeof' module_param_string(quirks, quirks_param, sizeof(quirks_param), 0644); ^~~~~~ drivers/usb/core/quirks.c:16:26: error: expected ')' before string constant MODULE_PARM_DESC(quirks, "Add/modify USB quirks by specifying quirks=vendorID:productID:quirks"); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +15 drivers/usb/core/quirks.c
13 14 static char quirks_param[128]; > 15 module_param_string(quirks, quirks_param, sizeof(quirks_param), 0644); 16 MODULE_PARM_DESC(quirks, "Add/modify USB quirks by specifying quirks=vendorID:productID:quirks"); 17
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [unhandled content-type:application/gzip] | |