Messages in this thread | | | From | Jassi Brar <> | Date | Wed, 28 Feb 2018 14:46:13 +0530 | Subject | Re: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver |
| |
On Wed, Feb 28, 2018 at 7:57 AM, Samuel Holland <samuel@sholland.org> wrote: ....
> +/* > + * The message box hardware provides 8 unidirectional channels. As the mailbox > + * framework expects them to be bidirectional > That is incorrect. Mailbox framework does not require a channel to be TX and RX capable.
You should expose each channel as per its physical capability, let the client configure it for direction (if its bidirectional) and acquire separate channels for RX and TX if it needs to.
Cheers!
| |