Messages in this thread | | | Subject | Re: [PATCH] xen/pirq: fix error path cleanup when binding MSIs | From | Juergen Gross <> | Date | Wed, 28 Feb 2018 20:22:01 +0100 |
| |
On 28/02/18 10:19, Roger Pau Monne wrote: > Current cleanup in the error path of xen_bind_pirq_msi_to_irq is > wrong. First of all there's an off-by-one in the cleanup loop, which > can lead to unbinding wrong IRQs. > > Secondly IRQs not bound won't be freed, thus leaking IRQ numbers. > > Note that there's no need to differentiate between bound and unbound > IRQs when freeing them, __unbind_from_irq will deal with both of them > correctly. > > Fixes: 4892c9b4ada9f9 ("xen: add support for MSI message groups") > Reported-by: Hooman Mirhadi <mirhadih@amazon.com> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Committed to xen/tip for-linus-4.16a
Juergen
| |