Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH] pvcalls-front: 64-bit align flags | Date | Wed, 28 Feb 2018 09:06:17 +0000 |
| |
From: Stefano Stabellini > Sent: 27 February 2018 19:55 > > We are using test_and_* operations on the status and flag fields of > struct sock_mapping. However, these functions require the operand to be > 64-bit aligned on arm64. Currently, only status is 64-bit aligned.
That sounds like a big accident just waiting to happen... If the operand is required to be 64bit aligned why isn't it a type that requires 64bit alignment?
> Make flags 64-bit aligned by introducing an explicit padding field.
At some point such padding will always go wrong...
David
| |