Messages in this thread | | | From | Bart Van Assche <> | Subject | Re: [PATCH] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert | Date | Tue, 27 Feb 2018 17:18:35 +0000 |
| |
On Tue, 2018-02-27 at 17:06 +0000, Bart Van Assche wrote: > On Tue, 2018-02-27 at 13:15 +0800, jianchao.wang wrote: > > Can you share more details about this ? > > After having had another look, I think your patch is fine.
(replying to my own e-mail)
What I think is fine in your patch is that it skips the unprep and reprep when requeueing. However, there is a put_device(&sdev->sdev_gendev) call in scsi_mq_requeue_cmd() and your patch causes that put_device() call to be skipped when requeueing. An explanation is needed in the commit message why you think that removing that put_device() call is fine.
Bart. | |