Messages in this thread | | | Date | Mon, 26 Feb 2018 12:15:14 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH] rcu: Remove the unnecessary separate function, rcu_preempt_do_callback() |
| |
On Mon, 26 Feb 2018 14:11:36 +0900 Byungchul Park <byungchul.park@lge.com> wrote:
> rcu_preemptp_do_callback() was introduced in commit 09223371dea(rcu: > Use softirq to address performance regression), where it had to be > distinguished between in the case CONFIG_TREE_PREEMPT_RCU is set and > it's not. > > Now that the code was cleaned up so that rcu_preemt_do_callback() is > only called in rcu_kthread_do_work() in the same file, tree_plugin.h, > we don't have to keep the separate function anymore. Remove it for a > better readability.
Looks good to me (looks like commit f8b7fc6b51 "rcu: use softirq instead of kthreads except when RCU_BOOST=y" cleaned up the ifdefs and removed the requirement).
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
| |