Messages in this thread | | | Date | Mon, 26 Feb 2018 11:33:29 -0500 (EST) | Subject | Re: [net-next PATCH 2/2] mlxsw: spectrum_kvdl: avoid uninitialized variable warning | From | David Miller <> |
| |
From: Arnd Bergmann <arnd@arndb.de> Date: Fri, 23 Feb 2018 14:15:32 +0100
> gcc warns that 'resource_id' is not initialized if we don't come though > any of the three 'case' statements before: > > drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c: In function 'mlxsw_sp_kvdl_part_init': > drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c:275:8: error: 'resource_id' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > In the current code, that won't happen, but it's more robust to explicitly > handle this by returning a failure from mlxsw_sp_kvdl_part_init. > > Fixes: 887839e6960d ("mlxsw: spectrum_kvdl: Add support for dynamic partition set") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
| |