lkml.org 
[lkml]   [2018]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 4/8] efi: Decode UEFI-defined IA32/X64 Error Structure GUIDs
Date
> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Saturday, February 24, 2018 11:41 AM
> To: Ghannam, Yazen <Yazen.Ghannam@amd.com>
> Cc: linux-efi@vger.kernel.org; Linux Kernel Mailing List <linux-
> kernel@vger.kernel.org>; Borislav Petkov <bp@suse.de>; the arch/x86
> maintainers <x86@kernel.org>
> Subject: Re: [PATCH 4/8] efi: Decode UEFI-defined IA32/X64 Error Structure
> GUIDs
>
> On 23 February 2018 at 20:03, Yazen Ghannam
> <Yazen.Ghannam@amd.com> wrote:
> > From: Yazen Ghannam <yazen.ghannam@amd.com>
> >
> > For easier handling, match the known IA32/X64 error structure GUIDs to
> > enums.
> >
> > Also, print out the name of the matching Error Structure Type.
> >
> > GUIDs taken from UEFI 2.7 section N.2.4.2.1 IA32/X64 Processor Error
> > Information Structure.
> >
> > Cc: <stable@vger.kernel.org> # 4.16.x
> > Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> > ---
> > drivers/firmware/efi/cper-x86.c | 41
> +++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 41 insertions(+)
> >
> > diff --git a/drivers/firmware/efi/cper-x86.c b/drivers/firmware/efi/cper-
> x86.c
> > index 9d608f742c98..3b86223bdb67 100644
> > --- a/drivers/firmware/efi/cper-x86.c
> > +++ b/drivers/firmware/efi/cper-x86.c
> > @@ -14,17 +14,53 @@
...
> > void cper_print_proc_ia(const char *pfx, const struct cper_sec_proc_ia
> *proc)
> > {
> > int i;
> > struct cper_ia_err_info *err_info;
> > char newpfx[64];
> > + enum err_types err_type;
> >
>
> Can you make this an u8 please? The signedness of an enum is not well
> defined, and you only check the upper bound below.
>

Yes, will do.

Thanks,
Yazen
\
 
 \ /
  Last update: 2018-02-26 17:02    [W:0.116 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site