Messages in this thread | | | Subject | Re: [PATCH 3/4] auxdisplay: charlcd: fix x/y address commands | From | Robert Abel <> | Date | Tue, 27 Feb 2018 00:05:10 +0100 |
| |
Hi Miguel,
On 26 Feb 2018 17:49, Miguel Ojeda wrote: > On Mon, Feb 26, 2018 at 12:54 AM, Robert Abel <rabel@robertabel.eu> wrote: >> + /* clamp new x/y coordinates */ >> + if (tmp_addr.x >= lcd->width) >> + tmp_addr.x = lcd->width - 1; > > tmp_addr.x = min(tmp_addr.x, lcd->width - 1);
Had throught of that, too. However, it introduces a warning about type mismatch, because lcd->width is int while tmp_addr.x is unsigned long int. I didn't fell like saving a line warranted much bigger changes to the lcd struct.
Regards,
Robert
| |