Messages in this thread | | | Subject | Re: [PATCH 4.14 00/54] 4.14.23-stable review | From | Dan Murphy <> | Date | Mon, 26 Feb 2018 15:56:56 -0600 |
| |
Tony
On 02/26/2018 03:45 PM, Tony Lindgren wrote: > * Guenter Roeck <linux@roeck-us.net> [180226 21:20]: >> On Mon, Feb 26, 2018 at 02:58:24PM -0600, Dan Murphy wrote: >>> Tony L/Greg >>> >>> On 02/26/2018 02:21 PM, Greg Kroah-Hartman wrote: >>>> This is the start of the stable review cycle for the 4.14.23 release. >>>> There are 54 patches in this series, all will be posted as a response >>>> to this one. If anyone has any issues with these being applied, please >>>> let me know. >>>> >>>> Responses should be made by Wed Feb 28 20:21:22 UTC 2018. >>>> Anything received after that time might be too late. >>>> >>> >>> We have a build issue on 4.14.22 and can be re-created with this rc as well. >>> >>> arch/arm/mach-omap2/omap-secure.o: In function `omap3_save_secure_ram': >>> omap-secure.c:(.text+0xe4): undefined reference to `save_secure_ram_context' >>> make: *** [vmlinux] Error 1 >>> >>> The issue was introduced with the back port of >>> >>> b59a1da647f163d0bf035f823a908b45c357643a ARM: OMAP2+: Fix SRAM virt to phys translation for save_secure_ram_context >>> >> Looks like you may have CONFIG_PM disabled, is that correct ? >> Is there a default configuration that we can use to reproduce >> the problem ? > > It should be fixed with this commit in mainline kernel: > > 863204cfdae9 ("ARM: omap2: hide omap3_save_secure_ram on non-OMAP3 builds")
Thanks for sharing. I cherry picked this into the failing build and it built successfully.
So can pull this into 4.14.23-rc. If our "TI next" merge cycle is successful we should see this error go away. We missed it last week because the offending commit caused a merge conflict with our TI tree.
I tested this against the multi_v7_defconfig with these CONFIG flags amended. Ignoring the override warnings CONFIG_SOC_AM43XX=y CONFIG_ARCH_OMAP2PLUS=y # Disable Socs other than AM43xx CONFIG_ARCH_OMAP2=n CONFIG_ARCH_OMAP3=n CONFIG_ARCH_OMAP4=n CONFIG_SOC_OMAP5=n CONFIG_SOC_AM33XX=n CONFIG_SOC_DRA7XX=n CONFIG_ARCH_KEYSTONE=n
Tested-by: Dan Murphy <dmurphy@ti.com>
> > Regards, > > Tony >
-- ------------------ Dan Murphy
| |