Messages in this thread | | | Subject | Re: [PATCH v12 3/3] mm, x86, powerpc: display pkey in smaps only if arch supports pkeys | From | Dave Hansen <> | Date | Mon, 26 Feb 2018 13:16:16 -0800 |
| |
On 02/21/2018 03:52 PM, Ram Pai wrote: > Currently the architecture specific code is expected to > display the protection keys in smap for a given vma. > This can lead to redundant code and possibly to divergent > formats in which the key gets displayed. > > This patch changes the implementation. It displays the > pkey only if the architecture support pkeys, i.e > arch_pkeys_enabled() returns true. This patch > provides x86 implementation for arch_pkeys_enabled(). > > x86 arch_show_smap() function is not needed anymore. > Deleting it.
This looks fine to me. Thanks for doing these, Ram.
Reviewed-by: Dave Hansen <dave.hansen@intel.com>
| |