Messages in this thread | | | Subject | Re: [PATCH 03/12] usb: typec: API for controlling USB Type-C Multiplexers | From | Hans de Goede <> | Date | Sun, 25 Feb 2018 13:13:38 +0100 |
| |
Hi,
On 16-02-18 15:00, Andy Shevchenko wrote: > On Fri, Feb 16, 2018 at 12:47 PM, Hans de Goede <hdegoede@redhat.com> wrote: >> USB Type-C connectors consist of various muxes and switches >> that route the pins on the connector to the right locations. >> The USB Type-C drivers need to be able to control the muxes, >> as they are the ones that know things like the cable plug >> orientation, and the current mode that was negotiated with >> the partner. >> >> This introduces a small API for registering and controlling >> cable plug orientation switches, and separate small API for >> registering and controlling pin multiplexer/demultiplexer >> switches that are needed with Accessory/Alternate Modes. > >> + sw = __device_find_connection(dev, "typec-switch", NULL, >> + typec_switch_match); > > Perhaps one line? (even if it takes ~83 characters)
I'm not a fan of breaking the 80 chars limit when we can reasonably cleanly split a statement (such as here), so I'm keeping this as is for v2.
Regards,
Hans
| |