lkml.org 
[lkml]   [2018]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 136/159] staging: ccree: Uninitialized return in ssi_ahash_import()
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>


    [ Upstream commit aece09024414b54158e03aa45f4a4436e7cb996c ]

    The return value isn't initialized on some success paths.

    Fixes: c5f39d07860c ("staging: ccree: fix leak of import() after init()")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/staging/ccree/ssi_hash.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/staging/ccree/ssi_hash.c
    +++ b/drivers/staging/ccree/ssi_hash.c
    @@ -1781,7 +1781,7 @@ static int ssi_ahash_import(struct ahash
    struct device *dev = &ctx->drvdata->plat_dev->dev;
    struct ahash_req_ctx *state = ahash_request_ctx(req);
    u32 tmp;
    - int rc;
    + int rc = 0;

    memcpy(&tmp, in, sizeof(u32));
    if (tmp != CC_EXPORT_MAGIC) {

    \
     
     \ /
      Last update: 2018-02-23 20:16    [W:4.067 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site