lkml.org 
[lkml]   [2018]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 054/159] binder: replace "%p" with "%pK"
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Todd Kjos <tkjos@android.com>

    commit 8ca86f1639ec5890d400fff9211aca22d0a392eb upstream.

    The format specifier "%p" can leak kernel addresses. Use
    "%pK" instead. There were 4 remaining cases in binder.c.

    Signed-off-by: Todd Kjos <tkjos@google.com>
    Cc: stable <stable@vger.kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/android/binder.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    --- a/drivers/android/binder.c
    +++ b/drivers/android/binder.c
    @@ -2141,7 +2141,7 @@ static void binder_transaction_buffer_re
    int debug_id = buffer->debug_id;

    binder_debug(BINDER_DEBUG_TRANSACTION,
    - "%d buffer release %d, size %zd-%zd, failed at %p\n",
    + "%d buffer release %d, size %zd-%zd, failed at %pK\n",
    proc->pid, buffer->debug_id,
    buffer->data_size, buffer->offsets_size, failed_at);

    @@ -3653,7 +3653,7 @@ static int binder_thread_write(struct bi
    }
    }
    binder_debug(BINDER_DEBUG_DEAD_BINDER,
    - "%d:%d BC_DEAD_BINDER_DONE %016llx found %p\n",
    + "%d:%d BC_DEAD_BINDER_DONE %016llx found %pK\n",
    proc->pid, thread->pid, (u64)cookie,
    death);
    if (death == NULL) {
    @@ -4991,7 +4991,7 @@ static void print_binder_transaction_ilo
    spin_lock(&t->lock);
    to_proc = t->to_proc;
    seq_printf(m,
    - "%s %d: %p from %d:%d to %d:%d code %x flags %x pri %ld r%d",
    + "%s %d: %pK from %d:%d to %d:%d code %x flags %x pri %ld r%d",
    prefix, t->debug_id, t,
    t->from ? t->from->proc->pid : 0,
    t->from ? t->from->pid : 0,
    @@ -5015,7 +5015,7 @@ static void print_binder_transaction_ilo
    }
    if (buffer->target_node)
    seq_printf(m, " node %d", buffer->target_node->debug_id);
    - seq_printf(m, " size %zd:%zd data %p\n",
    + seq_printf(m, " size %zd:%zd data %pK\n",
    buffer->data_size, buffer->offsets_size,
    buffer->data);
    }

    \
     
     \ /
      Last update: 2018-02-23 19:52    [W:4.106 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site