Messages in this thread | | | From | Linus Walleij <> | Date | Fri, 23 Feb 2018 15:09:45 +0100 | Subject | Re: [PATCH v2 3/5] gpio: Change ISA_BUS_API dependency to selection |
| |
On Fri, Feb 23, 2018 at 2:50 PM, Maciej S. Szmigiero <mail@maciej.szmigiero.name> wrote: > On 22.02.2018 21:44, Maciej S. Szmigiero wrote:
>> Note that gpio-winbond (CONFIG_GPIO_WINBOND) driver was originally >> merged using ISA_BUS_API selection as done for other ISA bus gpio drivers >> by this patch, then temporary switched to the previous ("depends on") >> style by commit 92a8046c9d952a to fix a circular Kconfig dependency. >> So now this commit (92...) should be reverted to make gpio-winbond >> driver Kconfig dependency / selection consistent with the remaining ISA >> bus gpio drivers. >> >> Unfortunately, I can't test the reversion myself because it looks like >> Linus didn't push his trees yet to git.kernel.org after applying this >> series (or I am not looking at the right place - linusw/linux-gpio.git?). > > It looks like the series has been pushed to git.kernel.org now. > I have tested the reversion of commit 92a8046c9d952a and can confirm > that the ISA_BUS_API dependency / selection for gpio-winbond works > then as intended (in a way that is consistent with other ISA bus gpio > drivers). > > @Linus: > Will you revert that commit or should I submit a patch that does it?
Oh send me a patch, that's easiest.
Yours, Linus Walleij
| |