lkml.org 
[lkml]   [2018]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3 2/2] x86/apic: Replace common tools with new ones
On Fri, Feb 23, 2018 at 9:54 AM, Dou Liyang <douly.fnst@cn.fujitsu.com> wrote:
> The pending interrupt check code is old, update the following code.
>
> -Replace for() with for_each_set_bit()

> - for (j = 31; j >= 0; j--) {
> - if (value & (1<<j)) {
> + for_each_set_bit(j, &value, 32) {

for_each_set_bit(), mind 'set' part, is equivalent to for-if pair...

> + if (j) {

...here you just exclude bit 0 from consideration by unknown reason.

> ack_APIC_irq();
> acked++;
> }
> }

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2018-02-23 13:41    [W:0.037 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site