Messages in this thread | | | Subject | Re: [PATCH] ARM: dts: da850: use gpio-ranges | From | Sekhar Nori <> | Date | Fri, 23 Feb 2018 17:14:56 +0530 |
| |
On Thursday 22 February 2018 09:04 PM, Linus Walleij wrote: > On Mon, Feb 19, 2018 at 11:29 PM, David Lechner <david@lechnology.com> wrote: > >> This makes use of the gpio-ranges feature that connects GPIO >> controllers and PINMUX controllers. >> >> In da850.dtsi, pinctrl-single,gpio-range is added to the pinmux node >> and gpio-ranges is added to the GPIO node. Unfortunately, the way the >> pinctrl-single driver enumerates the pins (starting with LSB) causes >> them to be in reverse order compared to the way the gpios are assigned. >> As a result, we have to declare the mapping for each GPIO individually. >> >> This also lets us remove all of the GPIO pinmuxes from >> da850-lego-ev3.dts. (Other da850 boards do not currently have any >> GPIO pinmuxes declared.) >> >> Signed-off-by: David Lechner <david@lechnology.com> > > Nice, > Acked-by: Linus Walleij <linus.wallei@linaro.org>
Looks good to me too. And quite painstakingly done!
I suppose this needs to wait a bit due to the dependencies? Let me know once its okay to merge.
Thanks, Sekhar
| |