Messages in this thread | | | Date | Fri, 23 Feb 2018 15:40:51 -0600 | From | Bjorn Helgaas <> | Subject | Re: [PATCH v1 4/4] pci: Re-use new dmi_get_bios_year() helper |
| |
Please use
PCI: Re-use ...
to match the prevailing drivers/pci style.
On Thu, Feb 22, 2018 at 02:59:23PM +0200, Andy Shevchenko wrote: > ...instead of open coding its functionality.
Same comment about making the changelog complete, independent of the subject.
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Let me know if you want me to take the series. Otherwise I'll assume it goes elsewhere.
> --- > drivers/pci/pci.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index f6a4dd10d9b0..ae654e21439d 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -2258,8 +2258,6 @@ void pci_config_pm_runtime_put(struct pci_dev *pdev) > */ > bool pci_bridge_d3_possible(struct pci_dev *bridge) > { > - unsigned int year; > - > if (!pci_is_pcie(bridge)) > return false; > > @@ -2287,10 +2285,8 @@ bool pci_bridge_d3_possible(struct pci_dev *bridge) > * It should be safe to put PCIe ports from 2015 or newer > * to D3. > */ > - if (dmi_get_date(DMI_BIOS_DATE, &year, NULL, NULL) && > - year >= 2015) { > + if (dmi_get_bios_year() >= 2015) > return true; > - } > break; > } > > -- > 2.16.1 >
| |