lkml.org 
[lkml]   [2018]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/3] mm/sparse: Add a static variable nr_present_sections
On 02/22/18 at 01:24pm, Andrew Morton wrote:
> On Thu, 22 Feb 2018 17:11:28 +0800 Baoquan He <bhe@redhat.com> wrote:
>
> > It's used to record how many memory sections are marked as present
> > during system boot up, and will be used in the later patch.
> >
> > --- a/mm/sparse.c
> > +++ b/mm/sparse.c
> > @@ -202,6 +202,7 @@ static inline int next_present_section_nr(int section_nr)
> > (section_nr <= __highest_present_section_nr)); \
> > section_nr = next_present_section_nr(section_nr))
> >
> > +static int nr_present_sections;
>
> I think this could be __initdata.
>
> A nice comment explaining why it exists would be nice.

Thanks, I will update as you suggested.
>

\
 
 \ /
  Last update: 2018-02-23 00:57    [W:0.085 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site