Messages in this thread | | | From | "Rafael J. Wysocki" <> | Date | Thu, 22 Feb 2018 22:49:36 +0100 | Subject | Re: [PATCH] PCMCIA / PM: Avoid noirq suspend aborts during suspend-to-idle |
| |
On Thu, Feb 22, 2018 at 6:32 PM, Rafael J. Wysocki <rafael@kernel.org> wrote: > On Thu, Feb 22, 2018 at 5:45 PM, Dominik Brodowski > <linux@dominikbrodowski.net> wrote: >> On Wed, Feb 21, 2018 at 01:24:16PM +0100, Rafael J. Wysocki wrote: >>> Avoid that by using a new socket state flag, SOCKET_IN_RESUME, >>> to indicate that socket_early_resume() has already run for the >>> socket in which case socket_suspend() will do minimum handling >>> and return 0. >> >> That looks to be *too* minimal: For example, yenta_socket does some >> socket set-up in ->init(), which is called by socket_early_resume(). >> That needs to be undone by ->suspend(). > > I see. > >> What about this variant (untested, not even compile-tested)? > > It looks fine to me, I'll test it later today.
I had to make it compile (by fixing a typo), but it works for me after that, so I'll queue it up.
Thanks, Rafael
| |