lkml.org 
[lkml]   [2018]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] MIPS: OCTEON: irq: check for null return on kzalloc allocation
From
Date
On 02/22/2018 10:08 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The allocation of host_data is not null checked, leading to a
> null pointer dereference if the allocation fails. Fix this by
> adding a null check and return with -ENOMEM.
>
> Fixes: 64b139f97c01 ("MIPS: OCTEON: irq: add CIB and other fixes")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: David Daney <david.daney@cavium.com>


> ---
> arch/mips/cavium-octeon/octeon-irq.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c
> index b993d9f2c9b9..203e1d2a56d5 100644
> --- a/arch/mips/cavium-octeon/octeon-irq.c
> +++ b/arch/mips/cavium-octeon/octeon-irq.c
> @@ -2277,6 +2277,8 @@ static int __init octeon_irq_init_cib(struct device_node *ciu_node,
> }
>
> host_data = kzalloc(sizeof(*host_data), GFP_KERNEL);
> + if (!host_data)
> + return -ENOMEM;
> raw_spin_lock_init(&host_data->lock);
>
> addr = of_get_address(ciu_node, 0, NULL, NULL);
>

\
 
 \ /
  Last update: 2018-02-22 19:11    [W:0.053 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site