lkml.org 
[lkml]   [2018]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC tip/locking/lockdep v5 14/17] Revert "locking/lockdep/selftests: Fix mixed read-write ABBA tests"
    Date
    This reverts commit d82fed75294229abc9d757f08a4817febae6c4f4.

    Since we now could handle mixed read-write deadlock detection well, the
    self tests could be detected as expected, no need to use this
    work-around.

    Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
    ---
    lib/locking-selftest.c | 8 --------
    1 file changed, 8 deletions(-)

    diff --git a/lib/locking-selftest.c b/lib/locking-selftest.c
    index 6b7a28d84fc4..79270288fa28 100644
    --- a/lib/locking-selftest.c
    +++ b/lib/locking-selftest.c
    @@ -2266,14 +2266,6 @@ void locking_selftest(void)
    print_testname("mixed read-lock/lock-write ABBA");
    pr_cont(" |");
    dotest(rlock_ABBA1, FAILURE, LOCKTYPE_RWLOCK);
    -#ifdef CONFIG_PROVE_LOCKING
    - /*
    - * Lockdep does indeed fail here, but there's nothing we can do about
    - * that now. Don't kill lockdep for it.
    - */
    - unexpected_testcase_failures--;
    -#endif
    -
    pr_cont(" |");
    dotest(rwsem_ABBA1, FAILURE, LOCKTYPE_RWSEM);

    --
    2.16.1
    \
     
     \ /
      Last update: 2018-02-22 08:08    [W:4.851 / U:0.460 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site