lkml.org 
[lkml]   [2018]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] ARM: dts: da850: use gpio-ranges
On Mon, Feb 19, 2018 at 11:29 PM, David Lechner <david@lechnology.com> wrote:

> This makes use of the gpio-ranges feature that connects GPIO
> controllers and PINMUX controllers.
>
> In da850.dtsi, pinctrl-single,gpio-range is added to the pinmux node
> and gpio-ranges is added to the GPIO node. Unfortunately, the way the
> pinctrl-single driver enumerates the pins (starting with LSB) causes
> them to be in reverse order compared to the way the gpios are assigned.
> As a result, we have to declare the mapping for each GPIO individually.
>
> This also lets us remove all of the GPIO pinmuxes from
> da850-lego-ev3.dts. (Other da850 boards do not currently have any
> GPIO pinmuxes declared.)
>
> Signed-off-by: David Lechner <david@lechnology.com>

Nice,
Acked-by: Linus Walleij <linus.wallei@linaro.org>

> + gpio-ranges = <&pmx_core 0 15 1>,
> + <&pmx_core 1 14 1>,
> + <&pmx_core 2 13 1>,
> + <&pmx_core 3 12 1>,
> + <&pmx_core 4 11 1>,
> + <&pmx_core 5 10 1>,
> + <&pmx_core 6 9 1>,
> + <&pmx_core 7 8 1>,
> + <&pmx_core 8 7 1>,
> + <&pmx_core 9 6 1>,
> + <&pmx_core 10 5 1>,
> + <&pmx_core 11 4 1>,
> + <&pmx_core 12 3 1>,
> + <&pmx_core 13 2 1>,
> + <&pmx_core 14 1 1>,
> + <&pmx_core 15 0 1>,

Heh the map moves backward how funny.

Sorry that we don't have an option to map that
any better in the ranges but hey, this works.

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2018-02-22 16:34    [W:0.093 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site