Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 22 Feb 2018 15:23:03 +0100 | Subject | Re: [PATCH v3 3/3] gpio: rcar: Use wakeup_path i.s.o. explicit clock handling |
| |
On Mon, Feb 12, 2018 at 2:55 PM, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> Since commit ab82fa7da4dce5c7 ("gpio: rcar: Prevent module clock disable > when wake-up is enabled"), when a GPIO is used for wakeup, the GPIO > block's module clock (if exists) is manually kept running during system > suspend, to make sure the device stays active. > > However, this explicit clock handling is merely a workaround for a > failure to properly communicate wakeup information to the device core. > > Instead, set the device's power.wakeup_path field, to indicate this > device is part of the wakeup path. Depending on the PM Domain's > active_wakeup configuration, the genpd core code will keep the device > enabled (and the clock running) during system suspend when needed. > This allows for the removal of all explicit clock handling code from the > driver. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Can I apply this and only this patch to GPIO?
Should it be applied for fixes, next?
Else please funnel this through the irqchip tree with my ACK.
Yours, Linus Walleij
| |