lkml.org 
[lkml]   [2018]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] iio:dummy: Replace S_IWUSR by 0200
> > Also who cares?  The commit message is perfectly clear.
>
> I do care about newcomers really learning on how to write a proper
> commit message.
>
> The commit messsage should really say why the patch is needed, no what the patch does.
>

It fixes a checkpatch warning. The warning was right there in the patch
description!

> After several trivial patches newcomers will get into more serious stuff and I wouldn't
> want to see a patch with commit message like this:
>
> iio: Change bit 1 of status register
>

You seem to be complaining about about an imaginary patch from the
future??? If you've really built a time machine then focus on killing
Hitler instead of complaining about trivial bullshit.

regards,
dan carpenter

\
 
 \ /
  Last update: 2018-02-22 09:27    [W:0.094 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site