Messages in this thread | | | Subject | Re: [PATCH v2] iio:dummy: Replace S_IWUSR by 0200 | From | Phil Reid <> | Date | Thu, 22 Feb 2018 16:11:29 +0800 |
| |
On 22/02/2018 04:01, Julia Lawall wrote: > > On Wed, 21 Feb 2018, Rodrigo Siqueira wrote: > >> This patch fixes the checkpatch.pl warning: >> >> drivers/iio/dummy/iio_dummy_evgen.c:151: WARNING: Symbolic permissions >> 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. > I haven't studied up on it in great detail, but isn't there a more > specific macro that doesn't need a permission argument at all? >
Probably thinking of IIO_DEVICE_ATTR_RO / IIO_DEVICE_ATTR_WO But they don't provide flexibility for the show / store method.
-- Regards Phil Reid
| |