Messages in this thread | | | Subject | Re: [PATCH net v2 1/2] Revert "tuntap: add missing xdp flush" | From | Sergei Shtylyov <> | Date | Thu, 22 Feb 2018 10:57:21 +0300 |
| |
On 2/22/2018 9:24 AM, Jason Wang wrote:
> This reverts commit 762c330d670e3d4b795cf7a8d761866fdd1eef49. The > reason is we try to batch packets for devmap which causes calling > xdp_do_flush() under the process context. Simply disable premmption
s/under/in/. Disabling preemption.
> may not work since process may move among processors which lead > xdp_do_flush() to miss some flushes on some processors. > > So simply revert the patch, a follow-up path will add the xdp flush > correctly. > > Reported-by: Christoffer Dall <christoffer.dall@linaro.org> > Fixes: 762c330d670e ("tuntap: add missing xdp flush") > Signed-off-by: Jason Wang <jasowang@redhat.com> [...]
MBR, Sergei
| |