lkml.org 
[lkml]   [2018]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.15 003/163] IB/qib: Fix comparison error with qperf compare/swap test
    Date
    4.15-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Mike Marciniszyn <mike.marciniszyn@intel.com>

    commit 87b3524cb5058fdc7c2afdb92bdb2e079661ddc4 upstream.

    This failure exists with qib:

    ver_rc_compare_swap:
    mismatch, sequence 2, expected 123456789abcdef, got 0

    The request builder was using the incorrect inlines to
    build the request header resulting in incorrect data
    in the atomic header.

    Fix by using the appropriate inlines to create the request.

    Fixes: 261a4351844b ("IB/qib,IB/hfi: Use core common header file")
    Reviewed-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
    Signed-off-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
    Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/infiniband/hw/qib/qib_rc.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/drivers/infiniband/hw/qib/qib_rc.c
    +++ b/drivers/infiniband/hw/qib/qib_rc.c
    @@ -434,13 +434,13 @@ no_flow_control:
    qp->s_state = OP(COMPARE_SWAP);
    put_ib_ateth_swap(wqe->atomic_wr.swap,
    &ohdr->u.atomic_eth);
    - put_ib_ateth_swap(wqe->atomic_wr.compare_add,
    - &ohdr->u.atomic_eth);
    + put_ib_ateth_compare(wqe->atomic_wr.compare_add,
    + &ohdr->u.atomic_eth);
    } else {
    qp->s_state = OP(FETCH_ADD);
    put_ib_ateth_swap(wqe->atomic_wr.compare_add,
    &ohdr->u.atomic_eth);
    - put_ib_ateth_swap(0, &ohdr->u.atomic_eth);
    + put_ib_ateth_compare(0, &ohdr->u.atomic_eth);
    }
    put_ib_ateth_vaddr(wqe->atomic_wr.remote_addr,
    &ohdr->u.atomic_eth);

    \
     
     \ /
      Last update: 2018-02-21 14:48    [W:4.048 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site