Messages in this thread | | | From | "Katsuhiro Suzuki" <> | Subject | Re: [PATCH 1/2] ASoC: add DT bindings documentation for ROHM BD28623 codec | Date | Wed, 21 Feb 2018 21:26:50 +0900 |
| |
Hello Mark,
Thank you for your review.
> -----Original Message----- > From: Mark Brown [mailto:broonie@kernel.org] > Sent: Wednesday, February 21, 2018 9:14 PM > To: Suzuki, Katsuhiro <suzuki.katsuhiro@socionext.com> > Cc: alsa-devel@alsa-project.org; Rob Herring <robh+dt@kernel.org>; devicetree@vger.kernel.org; Masami Hiramatsu > <masami.hiramatsu@linaro.org>; Jassi Brar <jaswinder.singh@linaro.org>; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH 1/2] ASoC: add DT bindings documentation for ROHM BD28623 codec > > On Wed, Feb 21, 2018 at 01:33:10PM +0900, Katsuhiro Suzuki wrote: > > > +Optional properties: > > +- VCCA-supply : regulator phandle for the VCCA supply > > +- VCCP1-supply: regulator phandle for the VCCP1 supply > > +- VCCP2-supply: regulator phandle for the VCCP2 supply > > These should be documented as mandatory unless the device genuinely > operates without power which seems unlikely.
Indeed, this IC does not work correctly if VCC power supply is lost. It's not optional. I'll fix it and send V2.
Regards, -- Katsuhiro Suzuki
| |